Skip to content

feat(assistant): add slide-up cancel feedback to push-to-talk - #351

Open
gac0812 wants to merge 3 commits into
1024XEngineer:mainfrom
gac0812:feat/push-to-talk-cancel-feedback
Open

feat(assistant): add slide-up cancel feedback to push-to-talk#351
gac0812 wants to merge 3 commits into
1024XEngineer:mainfrom
gac0812:feat/push-to-talk-cancel-feedback

Conversation

@gac0812

@gac0812 gac0812 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

变更

按住说话

  • 按住说话时提供即时短震动反馈
  • 在按钮上方显示固定的“滑到这里取消”位置,达到位置后高亮并震动
  • 松手取消时停止采集、关闭当前语音连接,不提交迟到的识别或命令结果

主页日历与详情

  • 完善日期标题布局,收窄账户栏并缩小标题字号,避免日期被截断
  • 修复选中非当天日期时圆形气泡变方形的问题
  • 统一地点、时间、提醒详情图标为尺寸一致的 SVG 图标

验证

  • Assistant 测试:115 passed
  • 日历/详情测试:23 passed
  • TypeScript、ESLint、Prettier passed

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.51282% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...istant/application/AssistantConversationService.ts 92.10% 6 Missing ⚠️
...assistant/presentation/useAssistantConversation.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

审查结论

手势阈值、震动反馈、录音连接清理以及取消后的迟到消息过滤整体衔接一致。取消发生在连接尚未完成时,当前实现仍会等待启动链收敛,导致界面已经结束按压但语音入口暂时无法再次启动;相关细节见行内评论。

验证方面,已逐项检查固定 SHA 差异及调用链。尝试运行两个聚焦 Jest 测试,但当前工作区未安装可用的本地测试依赖(vitest 无执行权限且本地 jest 模块不存在),因此未能在此环境复跑。

Comment thread frontend/src/features/assistant/application/AssistantConversationService.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant